Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.3 Package Shift #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Laravel 5.3 Package Shift #1

wants to merge 3 commits into from

Conversation

alibo
Copy link
Member

@alibo alibo commented Feb 15, 2017

This pull request includes the changes for upgrading your Laravel Package to Laravel 5.3. Feel free to commit any additional changes to the shift-2512 branch.

Before merging, you should:

  • Checkout the shift-2512 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the pre-commands fail, add --no-scripts)
  • Thoroughly test your code

This Shift is still in beta. If there were changes you feel could have been automated, please send your feedback to [email protected] or via Twitter.

The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
Laravel 5 adopted the short array syntax which became available in
PHP 5.4.
@alibo
Copy link
Member Author

alibo commented Feb 15, 2017

❌ Laravel 5.3 requires PHP 5.6.4+. You have an existing dependency for PHP in your composer.json. Ensure it meets the new version requirement of >=5.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants