Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fit procedure into outcome/validation metric/inference procedure #10

Open
nilshg opened this issue Jan 27, 2021 · 1 comment
Open

Refactor fit procedure into outcome/validation metric/inference procedure #10

nilshg opened this issue Jan 27, 2021 · 1 comment

Comments

@nilshg
Copy link
Owner

nilshg commented Jan 27, 2021

Ideally initially on the basis of the existing SynthControlModel as implemented, i.e. destructure into

  • outcome model (in this case simple convex hull, no intercept etc.)
  • minimization metric (here RMSE)
  • inference (here permutation test)
@nilshg
Copy link
Owner Author

nilshg commented Jan 27, 2021

@azev77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nilshg