Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] matrix: kwargs argument isn't passed through [hasfix] #136

Open
tobwen opened this issue Nov 9, 2024 · 0 comments · May be fixed by #135
Open

[bug] matrix: kwargs argument isn't passed through [hasfix] #136

tobwen opened this issue Nov 9, 2024 · 0 comments · May be fixed by #135

Comments

@tobwen
Copy link

tobwen commented Nov 9, 2024

bug

The keyword arguments aren't passed through on .matrix.

code example

matrix_locations=1 didn't make it to the backend.

from routingpy import Valhalla
from pprint import pprint

coords = [[13.413706, 52.490202], [13.421838, 52.514105], [13.453649, 52.507987], [13.401947, 52.543373]]
client = Valhalla(base_url='http://localhost:8002/')
matrix = client.matrix(locations=coords, profile='pedestrian', dry_run=True, matrix_locations=1)
print(matrix)

point in code

params.update(kwargs) is missing

if id:
params["id"] = id
return params

fix as pull request

#135

@tobwen tobwen linked a pull request Nov 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant