Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert adding generic V: Ordinal parameter to succ, pred, inc, dec" #22457

Closed
wants to merge 1 commit into from

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Aug 11, 2023

Reverts #22328

alternative to nim-lang/checksums#6

@konsumlamm
Copy link
Contributor

Is this really necessary? What's the problem with nim-lang/checksums#6?

This "feature" was introduced without any RFC, documentation, changelog entry, tests or review. I still think it's a bad idea to allow adding any two Ordinals. Wouldn't it be enough to add an overload for uint64 specifically (or SomeInteger)? Then at least we wouldn't be able to add *arbitrary Ordinals. It also breaks the JS backend, which currently relies on the second argument always being an int.

@ringabout
Copy link
Member Author

Wouldn't it be enough to add an overload for uint64 specifically (or SomeInteger)?

Perhaps, I will test that.

@ringabout
Copy link
Member Author

Doesn't += also support some integers as increments? Is that proc broken for JS as well?

@ringabout
Copy link
Member Author

Succeeded by #22470

@ringabout ringabout closed this Aug 14, 2023
@ringabout ringabout deleted the revert-22328-revert-ordinal branch August 14, 2023 01:16
@konsumlamm
Copy link
Contributor

konsumlamm commented Aug 14, 2023

Doesn't += also support some integers as increments? Is that proc broken for JS as well?

No, += only accepts arguments with the same type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants