feat: single-step IPNS setup #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mi-Lan
reviewed
Jan 18, 2023
Comment on lines
-107
to
-114
| export type AchRequest = { | ||
| ethereumAddress: Scalars['EthereumAddress']; | ||
| freeTextHandle?: InputMaybe<Scalars['Boolean']>; | ||
| handle?: InputMaybe<Scalars['CreateHandle']>; | ||
| overrideAlreadyClaimed: Scalars['Boolean']; | ||
| overrideTradeMark: Scalars['Boolean']; | ||
| secret: Scalars['String']; | ||
| }; |
There was a problem hiding this comment.
does it make sense to change generated files?
There was a problem hiding this comment.
These were changed after doing npm run i and npm run codegen. They should be in .gitignore tbh
adamazad
commented
Jan 18, 2023
| "react-frame-component": "^5.2.3", | ||
| "react-frame-component": "^5.2.6", |
There was a problem hiding this comment.
This fixes ryanseddon/react-frame-component#236
Mi-Lan
reviewed
Jan 19, 2023
Comment on lines
+67
to
+123
| export async function getServerSideProps( | ||
| context: GetServerSidePropsContext<{ | ||
| domain: string; | ||
| }> | ||
| ): Promise<{ | ||
| props: CreateNimiPageProps; | ||
| }> { | ||
| let props = { | ||
| availableThemes: [], | ||
| domain: context?.params?.domain, | ||
| initialNimi: {} as Nimi, | ||
| poapList: [], | ||
| } as CreateNimiPageProps; | ||
|
|
||
| try { | ||
| if (!context?.params?.domain || context?.params?.domain === '[object Object]') { | ||
| throw new Error('No domain provided'); | ||
| } | ||
|
|
||
| const domain = context.params.domain; | ||
| // Nimi Snapshot from the API | ||
| const nimiIPNSSnapshot = await fetchNimiIPNS(domain); | ||
| // If the user has a Nimi IPNS, redirect to the Nimi page | ||
| if (nimiIPNSSnapshot.ipns && nimiIPNSSnapshot.nimi) { | ||
| props = { | ||
| ...props, | ||
| ipnsKey: nimiIPNSSnapshot.ipns, | ||
| nimiSnapshot: nimiIPNSSnapshot.nimi, | ||
| initialNimi: nimiIPNSSnapshot.nimi.nimi, | ||
| }; | ||
| } else { | ||
| const { nimi } = await generateNimiFromENS(domain); | ||
| props['initialNimi'] = nimi; | ||
| } | ||
|
|
||
| if (!props.initialNimi) { | ||
| throw new Error('No Nimi found'); | ||
| } | ||
|
|
||
| // Attempt to load | ||
| const poapList = await fetchUserPOAPs(props.initialNimi.ensAddress as string); | ||
| const availableThemes = getAvailableThemesByPOAPs(poapList); | ||
|
|
||
| if (poapList) { | ||
| props = { | ||
| ...props, | ||
| poapList, | ||
| availableThemes, | ||
| }; | ||
| } | ||
| } catch (e) { | ||
| console.log(e); | ||
| } | ||
| // If the user doesn't have a Nimi IPNS, generate a Nimi from the ENS name | ||
| return { props }; | ||
| } | ||
|
|
There was a problem hiding this comment.
there is still a way to use reactQuery with ssr here is article https://tanstack.com/query/latest/docs/react/guides/ssr?from=reactQueryV3&original=https%3A%2F%2Freact-query-v3.tanstack.com%2Fguides%2Fssr#using-initialdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking changes. This requires using of the Nimi API v2.0.
The single setup works by creating a temporary IPNS record. Then, convert it to a permanent record once the user submits the on-chain IPNS record as their ENS name's
contentHash.This works because only the owner and controller can update the ENS names, there's no need to verify the IPNS record ownership using signatures.
Besides addressing #236, this PR includes some fixes to the next.js hydration problems reported by @bejzik8.