Nimi Themes Naming improvement #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@adamazad also would be good to make sure that themes on older profiles are backward compatible |
|
I would merge it but would be good to have mapping of old values to new one on the server so that previously published profiles would work as intended when we repopulate data...I guess thats on @adamazad |
adamazad
force-pushed
the
development
branch
2 times, most recently
from
0ee4978 to
be7fa40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates naming of Nimi themes in
Nimi Appas per the changes made onNimi Cardrepository in this pull request.Together with the above mentioned pull request, resolves #281.
P.S. @adamazad, after merging, during the new release improve
Nimi Card's dependency.🍀