Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong content-type header in RPC responses #3130

Open
sisou opened this issue Nov 22, 2024 · 2 comments
Open

Wrong content-type header in RPC responses #3130

sisou opened this issue Nov 22, 2024 · 2 comments

Comments

@sisou
Copy link
Member

sisou commented Nov 22, 2024

The rpcserver crate is returning application/json-rpc instead of just application/json. This is there since that crate was created.

https://github.com/nimiq/jsonrpc/blob/a089737987cdff99f1271f2f8a7fd547fdea3621/server/src/lib.rs#L220

This is messing with some service providers/exchanges automated setup.

@hrxi
Copy link
Contributor

hrxi commented Nov 22, 2024

I couldn't find an official mime type for JSONRPC in the spec, so I guess we can just change to application/json if that's useful to some people.

@sisou
Copy link
Member Author

sisou commented Nov 22, 2024

@hrxi I made the commit in https://github.com/nimiq/jsonrpc, can you please make a release and use it in core-rs-albatross?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants