Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded "true" for use_extensions in fromProtoValue #59

Open
vrih opened this issue May 13, 2016 · 0 comments
Open

Hardcoded "true" for use_extensions in fromProtoValue #59

vrih opened this issue May 13, 2016 · 0 comments

Comments

@vrih
Copy link

vrih commented May 13, 2016

All of the calls to fromProtoValue and getValAt in PersistentProtocolBufferMap have the use_extensions parameter hard coded to true. This causes runtime failures on schemas that don't use extensions.

To workaround for my specific schema I've had to build with line 393, line 713 and line 718 hardcoded to false. I assume there's a way to detect this but I'm not familiar enough with protobufs yet to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant