p2pd: do not close an fd that is not open

Coverity: CID 739656 (#6 of 8): Argument cannot be negative (NEGATIVE_RETURNS) At (7): "capturingSkfd" is passed to a parameter that cannot be negative. Signed-off-by: Ferry Huberts <[email protected]>
ninuxorg · Oct 23, 2012 · 0abbc30 · 0abbc30
1 parent 4a65c93
commit 0abbc30
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/p2pd/src/NetworkInterfaces.c b/lib/p2pd/src/NetworkInterfaces.c
@@ -213,7 +213,9 @@ CreateInterface(const char *ifName, struct interface *olsrIntf)
   ifr.ifr_name[IFNAMSIZ - 1] = '\0';    /* Ensures null termination */
   if (ioctl(ioctlSkfd, SIOCGIFHWADDR, &ifr) < 0) {
     P2pdPError("ioctl(SIOCGIFHWADDR) error for interface \"%s\"", ifName);
-    close(capturingSkfd);
+    if (capturingSkfd >= 0) {
+      close(capturingSkfd);
+    }
     free(newIf);
     return 0;
   }