Kloenk's changes #301
Kloenk's changes #301
Conversation
| @@ -43,7 +43,7 @@ struct ReverseList<Element, Content>: View where Element: Identifiable, Content: | |||
| } | |||
| .frame(height: 30) // FIXME: Frame height shouldn't be hard-coded | |||
| .onPreferenceChange(IsVisibleKey.self) { | |||
| hasReachedTop = $0 | |||
| if $0 != hasReachedTop { hasReachedTop = $0 } | |||
There was a problem hiding this comment.
It seems I was talking nonsense. .onChange does in fact check for unique values, it's .onReceive that doesn't. Sorry!
There was a problem hiding this comment.
Ok, so removing that if?
As you may see I now create the other timeline, which does not create this error.
There was a problem hiding this comment.
Yeah I'd say so, it's not doing anything. Good to hear you've fixed the error 👍
I haven't had much of a look through as I find myself waiting to learn about Swift concurrency until after I've got the hang of Objective-C (which seems a slightly bizarre situation to be in 😆).
|
This now contains quite a log of changes. As It does not seem to get merged into swift-5.5 soon, I will just continue to dump my changes here. to make it easier for me |
|
This will stay a draft, until everything is implemented in the iOS 15 branch, then this will be closed without merging. |
This moves all trivial if macOS code into the Mio folder
Contains: #300