Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework 4D tools so that they do not depend on ComputationUI anymore #33

Open
4 tasks
Brow71189 opened this issue May 10, 2024 · 2 comments
Open
4 tasks

Comments

@Brow71189
Copy link
Collaborator

Brow71189 commented May 10, 2024

All tools in here: https://github.com/nion-software/experimental/tree/master/nionswift_plugin/nion_experimental_4dtools

They use very old code that is hard to maintain and we get frequent bug reports about it from users.

  • Most importantly, we need to remove the dependency on ComputationUI because that was a hack implemented before we had a proper way for defining custom UI in computations.

  • Also these tools should use these functions: https://github.com/nion-software/niondata/blob/master/nion/data/MultiDimensionalProcessing.py as much as possible for the actual data processing part.

  • Finally we should think about removing computations that are not needed anymore. As far as I can tell we do not need the special dark subtracion routines anymore, so I'd like to remove those instead of reworking them

  • Think about a better menu structure for our "experimental" tools: I'm not very happy with how they are spread across different menus. Some items are prefixed with [EXPERIMENTAL] in their title, some aren't. Maybe we could have one "experimental" menu item where all the experimental tools go. Once we merge one into stable they will move out of the experimental menu but there should be a note that this tool was moved for at least one release.

@cmeyer
Copy link
Contributor

cmeyer commented May 10, 2024

@cmeyer
Copy link
Contributor

cmeyer commented Jul 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants