Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence acquisition fails when camera exposure long enough to return a single image per second #203

Closed
Ion-e opened this issue Oct 24, 2024 · 10 comments

Comments

@Ion-e
Copy link

Ion-e commented Oct 24, 2024

With the shown parameters in the image. (Acquired item is number 10 on the image)

This issue is to figure out why it has failed, and whether it's an issue or not.

Image

@cmeyer
Copy link
Collaborator

cmeyer commented Oct 24, 2024

This belongs in https://github.com/nion-software/nionswift-instrumentation-kit/issues

However, without a procedure reproduce it, I'd suggest closing it. It is covered under other issues already, like these and some other internal issues.

@cmeyer cmeyer transferred this issue from nion-software/nionswift Oct 25, 2024
@Ion-e
Copy link
Author

Ion-e commented Oct 29, 2024

This bug is a bit of a mess.

The original issue was triggered with the following parameters:
Image

However there seems to be a different issue whilst doing an acquisition with the following parameters:
Image

I have managed to reproduce the latest one, do you want me to close this ticket and create 2 new tickets for them? @cmeyer

@Ion-e
Copy link
Author

Ion-e commented Nov 28, 2024

Verified as persisting. @cmeyer, the error now looks more detailed, do you think we should still close the issue?

@jamesrussell216
Copy link

@Ion-e can you check with @Brow71189 or @bentps whether we're trying to do something non-sensicle here!

@cmeyer
Copy link
Collaborator

cmeyer commented Jan 27, 2025

Fresh launch of Swift, run scan briefly, stop it, then use these parameters and it seems to work for me with latest version. So I can't reproduce this issue without further info.

Image

@Ion-e
Copy link
Author

Ion-e commented Jan 28, 2025

Confirmed this happens consistently.

Image

@jamesrussell216
Copy link

Happens for me too. @cmeyer try it with "Spectra" selected instead of "Image"...

Image

Stack trace:
Acquisition (Acquire) started: 2025-01-29 15:00:29.296122
Traceback (most recent call last):
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 3028, in acquire
data_stream_.send_raw_data_stream_event_to_data_handler(raw_data_stream_event)
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 689, in send_raw_data_stream_event_to_data_handler
self.__unprocessed_data_handler.handle_data_available(data_stream_event)
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 2521, in handle_data_available
self.send_packet(packet)
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 2513, in send_packet
self.__data_handler.handle_data_available(packet)
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 2794, in handle_data_available
self.__framer.data_available(packet, typing.cast(FrameCallbacks, self))
File "c:\nionapps\swift\nionswift-instrumentation-kit\nion\instrumentation\Acquisition.py", line 1828, in data_available
source_data = data_stream_event.source_data.reshape(data_stream_event.source_data.shape[1:])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: cannot reshape array of size 32768 into shape (512,)
Acquisition (Acquire) finished: 2025-01-29 15:00:32.162712 canceled with error

@cmeyer cmeyer self-assigned this Jan 29, 2025
@cmeyer cmeyer added audience - user affects users effort - day a day or less impact - critical has no practical workaround and prevents regular use reach - small affects a few users weekly skill level - expert skill level tag skill - acquisition skill tag labels Jan 29, 2025
@cmeyer cmeyer changed the title Acquisition has failed Sequence acquisition fails when camera exposure long enough to return a single image per second Jan 29, 2025
@cmeyer cmeyer closed this as completed in d44728a Jan 29, 2025
@Ion-e
Copy link
Author

Ion-e commented Jan 31, 2025

Aclaration, there seems to be a few different errors here and last few comments only addresses the last issue.

Other potential issues still pending of repro and validation.

@Ion-e Ion-e reopened this Jan 31, 2025
@cmeyer cmeyer removed audience - user affects users effort - day a day or less impact - critical has no practical workaround and prevents regular use reach - small affects a few users weekly skill level - expert skill level tag skill - acquisition skill tag labels Jan 31, 2025
@cmeyer
Copy link
Collaborator

cmeyer commented Jan 31, 2025

If there are other issues, can you file them individually in new issues and close this one?

@cmeyer cmeyer removed their assignment Jan 31, 2025
@Ion-e
Copy link
Author

Ion-e commented Feb 4, 2025

Both issues confirmed as fixed.

Thanks!

@Ion-e Ion-e closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants