Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval graphics are able to be taken out of the range of the 1d plot #1289

Open
Ion-e opened this issue Dec 13, 2024 · 6 comments
Open

Interval graphics are able to be taken out of the range of the 1d plot #1289

Ion-e opened this issue Dec 13, 2024 · 6 comments

Comments

@Ion-e
Copy link

Ion-e commented Dec 13, 2024

Specifically to 1D plot graphics as these items are not able to be zoomed in or out.

this type of graphic should have a hard limit

Image

@jamesrussell216
Copy link

@Ion-e I'm not sure I understand this one from what's written here?

@Ion-e
Copy link
Author

Ion-e commented Jan 27, 2025

Take a line profile graphic and drag it out of the display item completely. > The linre profile graphic will go completely out of the range of the 1D graph.

@cmeyer
Copy link
Collaborator

cmeyer commented Jan 27, 2025

It's not the ideal user experience, but this is intentional behavior as it allows measuring along an edge without changing the shape of the line profile graphic. I'm open to other ideas of how to handle it.

@Ion-e
Copy link
Author

Ion-e commented Jan 28, 2025

I would say a blocker so that the Graphic doesn't extend over the line graph would be something I would go for. Whether you would want the block to happen at the beggining of the line profile or after the end, it's not up for me to decide.

@jamesrussell216
Copy link

Could you limit it so the mid point of the graphic can't go beyond the limit? That way you can stop it flying off the plot but still allow easy measurement over the edge?

@cmeyer
Copy link
Collaborator

cmeyer commented Jan 29, 2025

Adding limits to graphics is complicated to implement due to the huge number of side cases, e.g. user enters value in inspector, what happens? A good workaround for this is: don't do that. Does there need to be more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants