-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BrainVoyager VTC, MSK, VMR and NR-VMP files #216
Open
thomastweets
wants to merge
9
commits into
nipy:master
Choose a base branch
from
thomastweets:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 17, 2016
-
First implementation. Copy of LabeledWrapStruct without inheritance.
Implement Vtc File NF: implement read and write for BrainVoyager QX VTC files NF+RF: implement read and write support for BrainVoyager QX MSK files and refactor bv.py NF: implement read and write support for BrainVoyager QX NR-VMP files TST: add test data for BrainVoyager QX files (VTC, MSK, and NR-VMP files) RF: create additional CArrayProxy class to work with C array memory layouts. RF: BvFileHeader inherits from LabeledWrapStruct BF: implement default_structarr for VMP files; NF: implement new set_shape method (with alternative propoerty zyx) for BrainVoyager file formats NF+BF+RF+TST: major refactor of BV formats implementation. Add tests for BV formats. Add affine for BV formats. RF: change side effect of update_header methods NF: VMP files can change shape (with _add_submap and _rem_submap) BF: change default values for vmp submaps; look for value (instead of key) when setting a string in the header BF: save old hdr when for transferring keys when changing the number of maps BF: change dtype of RGB fields to u1 BF: correct they way that nested dtypes of strings (length) are changed for VMP files BF: default_structarr for VMP header fills map1 and not map2 BF: in __setitem__ check for basestring; remove setString method NF: Implement basic support for some BrainVoyager QX file formats. This is a squashed commit for implementing basic BrainVoyager QX files support. See below for the single commit messages. First implementation. Copy of LabeledWrapStruct without inheritance. Implement Vtc File NF: implement read and write for BrainVoyager QX VTC files NF+RF: implement read and write support for BrainVoyager QX MSK files and refactor bv.py NF: implement read and write support for BrainVoyager QX NR-VMP files TST: add test data for BrainVoyager QX files (VTC, MSK, and NR-VMP files) RF: create additional CArrayProxy class to work with C array memory layouts. RF: BvFileHeader inherits from LabeledWrapStruct BF: implement default_structarr for VMP files; NF: implement new set_shape method (with alternative propoerty zyx) for BrainVoyager file formats NF+BF+RF+TST: major refactor of BV formats implementation. Add tests for BV formats. Add affine for BV formats. RF: change side effect of update_header methods NF: VMP files can change shape (with _add_submap and _rem_submap) BF: change default values for vmp submaps; look for value (instead of key) when setting a string in the header BF: save old hdr when for transferring keys when changing the number of maps BF: change dtype of RGB fields to u1 BF: correct they way that nested dtypes of strings (length) are changed for VMP files BF: default_structarr for VMP header fills map1 and not map2 BF: in __setitem__ check for basestring; remove setString method RF+TEST: Change the header parsing for BV file formats and implement tests. The BV file headers are now parsed using an OrderedDict. Tests are implemented for VtcImage. Only the VtcImage class is adapted to the new header parsing. DOC+PL+RF: Adding documentation and linting to bv.py. Let readCString return a list instead of a generator. PL: Removing blank lines. RF: Simplify and centralize the bv hdr prototype. Header prototypes are defined per BV filetype as nested tuples. The creation of an OrderedDict header is done centrally for all filetypes in bv.py based on these prototypes. WIP: separating prototype and default header Refactor the prototype format to make it a little easier to use. Pass the prototype into functions working with the header, to provide read / write format information. Return headers with (key, value) pairs, where the `value` is a value or a list, rather than a dict. WIP: Adapt BV MSK file implementation to new hdr. STY: flake8-compatible code. RF: move files into brainvoyager subdirectory. STY: Prepend "Bv" to all brainvoyager classes. BF: merge new protoHeader implementation into refactored bv files. BF: fix automatic filetype guessing for BV formats. NF : support for VMR file format TEST: add test_bv_vmr TEST: add test_bv_vmr TEST: add test_bv_vmr TEST: add test_bv_vmr Update check_vmr.txt TEST: add test_bv_vmr TEST: add test_bv_vmr TEST: add test_bv_vmr BF: BvVmr __init__ imports correct. BF: Adapt naming convention in bv_vmr.py. BF: Change set_data_shape() to include start values. BF: Change set_data_shape() to include start values in bv_msk.py. BF: Adapt bv_vmp to new hdr_dict format. WIP: Adapt bv_vmr implementation to naming standards. TST: Add image_api tests for BrainVoyager file formats. PL: Lint bv_vmr.py. PL: Lint bv_msk.py. BF: Add nibabel.brainvoyager to setup.py. BF: Enable automatic filetype guessing for bv_vmr. TEST: Adapt test_bv.py to new naming convention. TEST: Fix and clean test_bv_vmr.py. BF: Delete double function definitions in bv.py. TEST: Move get_base_affine docstring text to test_bv_vtc. PL: Lint all BV modules. BF: Correct parameter order for BvVmrHeader methods (ZYX). TEST: Move BV tests into brainvoyager/tests. DOC: Correct docstring for get_base_affine in BvFileHeader. TEST: Fix import paths after move of BV tests. TEST: Fix file handling error in test_bv. TEST: Fix test_bv file read ('rb'). TEST: Add BV file formats to more test cases. OPT: Make MGHHeader raise HeaderDataError in set_data_dtype instead of MGHError. BF: Raise HeaderDataError in BV file formats and continue when parsing conditional BV header fields. NF: Add function to check for supported dimensions in spatialimages. TEST: Fix test_files_interface tests for file formats with unsupported dtypes/dimensions. TEST: test_bad_dtype_mgh asserts an HeaderDataError. TEST+BF: Fix tests for BV and MGH file formats. Add update_BV_header function to account for nested header fields. NF: Compute combined inverse spatial transformation for BV VMR files. BF: correct import for BV EXAMPLE_IMAGES. TEST: Correct test_image_api for BV VMR file format. BF: Fix import of nibabel.brainvoyager.tests module. BF: Correct usage of bytes literals in bv.py and corresponding tests. TEST: Fix BV tests for Python 3.x TEST: Remove del command from BV test. TEST: Add temporary debug prints to test_image_api. TEST: Add file close command to test_bv. TEST: Fix supported_dimensions tests for numpy>=1.12. PL: Correct BV files. PL: Correct bv_vmr.py. OPT: Make BV variable names and header fields more pythonic. TEST: Fix numpy.rint warning issue in test_image_api. TEST+BF: Add a lot of BV tests.
Configuration menu - View commit details
-
Copy full SHA for 4699742 - Browse repository at this point
Copy the full SHA 4699742View commit details -
Configuration menu - View commit details
-
Copy full SHA for a87853d - Browse repository at this point
Copy the full SHA a87853dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a13fd2 - Browse repository at this point
Copy the full SHA 9a13fd2View commit details
Commits on Aug 18, 2016
-
Configuration menu - View commit details
-
Copy full SHA for d2929fc - Browse repository at this point
Copy the full SHA d2929fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9da49dc - Browse repository at this point
Copy the full SHA 9da49dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaa9a95 - Browse repository at this point
Copy the full SHA aaa9a95View commit details
Commits on Sep 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 880b89a - Browse repository at this point
Copy the full SHA 880b89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd34b5 - Browse repository at this point
Copy the full SHA fdd34b5View commit details
Commits on Feb 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 351ca44 - Browse repository at this point
Copy the full SHA 351ca44View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.