Feature/es price #81
Merged
Feature/es price #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willu47
reviewed
Mar 27, 2019
| - seasons | ||
| dtype: float | ||
| - name: gas_price | ||
| unit: GBP/MWh |
There was a problem hiding this comment.
Is GBP/MWh the correct unit for gas price? Might be mcm?
There was a problem hiding this comment.
the natural gas price usually states in £/MWh (alternatively £/kWh)
There was a problem hiding this comment.
I suggest to leave the units unchanged @tomalrussell @willu47
LahiruJayasuriya
requested changes
Mar 27, 2019
There was a problem hiding this comment.
Can you also add biomass? This is to come with the next update/release. Probably easy to implement now since you are already engaged with fuel prices.
This .zip contains data for biomass.
price V2.zip
LahiruJayasuriya
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load energy supply fuel prices from smif input
Introduces two bits of tech debt:
Towards #80