Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using CMake's ExternalProject feature #20

Open
JamiKettunen opened this issue Feb 10, 2023 · 2 comments
Open

Start using CMake's ExternalProject feature #20

JamiKettunen opened this issue Feb 10, 2023 · 2 comments

Comments

@JamiKettunen
Copy link

As I saw in #19 (comment) the repo currently uses git submodules; would it be possible to start using CMake's ExternalProject feature instead?

I also noticed https://github.com/nitanmarcel/cinny-click-packaging/tree/main/libs/qhttp which appears to just be in-tree copy of https://github.com/azadkuh/qhttp? Similar treatment could be given to that; if it's patched ExternalProject also can handle that.

@nitanmarcel
Copy link
Owner

As I saw in #19 (comment) the repo currently uses git submodules; would it be possible to start using CMake's ExternalProject feature instead?

I also noticed https://github.com/nitanmarcel/cinny-click-packaging/tree/main/libs/qhttp which appears to just be in-tree copy of https://github.com/azadkuh/qhttp? Similar treatment could be given to that; if it's patched ExternalProject also can handle that.

With qhhtp the thing is that it's a .pri project, and I have no idea if CMake handles that, so the in-tree copy has been made to create a CMakeLists.txt file I can use.

@JamiKettunen
Copy link
Author

JamiKettunen commented Feb 10, 2023

Worst case scenario is it can be added with a patch file, but it seems there's a PATCH_COMMAND you can use to for example use your own script to do what's needed, or just simply copy the CMakeLists.txt in-place to the SOURCE_DIR of the ExternalProject :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants