fix(rollup): replace globalThis.process. with process.

[Hebilicious]

🔗 Linked issue

fix: #1346
fix: nuxt/nuxt#21768

see vite PR logic: vitejs/vite#12194

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Some packages uses globalThis.process.env.NODE_ENV instead of process.env.NODE_ENV, which isn't supported by default by rollup. Vite supports this and so does Nuxt, so this changes brings the exact same feature to the rollup config for Nitro.

See issue in graphql-js

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

Merging #1360 (682f85f) into main (414f5f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   76.58%   76.59%           
=======================================
  Files          71       71           
  Lines        7223     7224    +1     
  Branches      718      718           
=======================================
+ Hits         5532     5533    +1     
  Misses       1690     1690           
  Partials        1        1           

Impacted Files	Coverage Δ
src/rollup/config.ts	90.74% <100.00%> (+0.01%)	⬆️

[Hebilicious]

@pi0
There's a more elegant fix suggested by @phryneas, which would be to use the delimiters options from rollup replace plugin with this regex :

delimiters: ['(?<!\\.)\\b', '\\b(?!\\.)']

However, I'm not sure if that would introduce any breaking change. So maybe this could be done in another PR as a feat, and we could also extend the nitro config to allow custom options for maximum flexibility.

https://github.com/rollup/plugins/tree/master/packages/replace#delimiters

Note that I also opened an upstream issue with rollup directly rollup/plugins#1524

[phryneas]

This one might still be useful - my suggestion would only prevent foo.process.env.NODE_ENV to be replaced with foo."production" in general, but it won't replace the full term with "production".
It only prevents the bug (and future ones), it doesn't improve the behaviour.

[Hebilicious]

This one might still be useful - my suggestion would only prevent foo.process.env.NODE_ENV to be replaced with foo."production" in general, but it won't replace the full term with "production". It only prevents the bug (and future ones), it doesn't improve the behaviour.

I tried the delimiters option alone, and it does fix this specific issue (ie globalThis.process.env.NODE_ENV gets transformed into "production").
I still think this fix is appropriate as we're sure that we don't break anything now, as technically changing the delimiters could break someone code who relies on this weird transform behaviour.

[pi0]

Thanks!