Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/boot/EFI/memtest86/memtest.efi is not signed #273

Open
Kreyren opened this issue Dec 27, 2023 · 5 comments
Open

/boot/EFI/memtest86/memtest.efi is not signed #273

Kreyren opened this issue Dec 27, 2023 · 5 comments

Comments

@Kreyren
Copy link

Kreyren commented Dec 27, 2023

image

Is there a way to make it sign memtest set through boot.loader.systemd-boot.memtest86.enable ?

@nikstur
Copy link
Member

nikstur commented Dec 27, 2023

We would need to implement this in Lanzaboote. There currently is no out of the box way to do it.

@Kreyren
Copy link
Author

Kreyren commented Dec 27, 2023

We would need to implement this in Lanzaboote. There currently is no out of the box way to do it. -- @nikstur (#273 (comment))

if let Some(specialisation_name) = &generation.specialisation_name {

# Blind code, untested, meant to show the intention only
if let Some(specialisation_name) = &generation.specialisation_name {
    Ok(PathBuf::from(format!(
        "nixos-generation-{}-specialisation-{}-{}.efi",
        generation, specialisation_name, stub_input_hash
    )))
+ } else if let Some(specialisation_name) = "memtest.efi" {
+     Ok(PathBuf::from("memtest.efi"))
} else {
    Ok(PathBuf::from(format!(
        "nixos-generation-{}-{}.efi",
        generation, stub_input_hash
    )))
}

Is it this easy or does it need additional changes somewhere else? Would probably be better to add some kind of management in nix to make nixos configuration more manageable as not everyone might want to sign the memtest

@RaitoBezarius
Copy link
Member

It would require more than that.

@kuflierl
Copy link
Contributor

kuflierl commented Jul 31, 2024

@Kreyren wouldn't your change sign any binary names memtest.efi without checking its contents? Wouldn't that potentially also sign a malicious binary if it was replaced prior?

@MithicSpirit
Copy link

Yeah, maybe it should compare the file's checksum with that from the nix store, or maybe even use a hardcoded checksum.

@CertainLach CertainLach mentioned this issue Aug 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants