Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if LVM snapshots are being used #5

Open
brianmcgee opened this issue Jun 12, 2024 · 2 comments
Open

Detect if LVM snapshots are being used #5

brianmcgee opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@brianmcgee
Copy link
Collaborator

For reference https://github.com/NixOS/nixpkgs/blob/dac9cdf8c930c0af98a63cbfe8005546ba0125fb/nixos/modules/installer/tools/nixos-generate-config.pl#L265-L268

@brianmcgee brianmcgee added the enhancement New feature or request label Jun 12, 2024
@brianmcgee brianmcgee changed the title Prevent unbootable systems if LVM snapshots are present at boot time Detect if LVM snapshots are being used Aug 1, 2024
@brianmcgee brianmcgee moved this to Todo in NixOS Facter Aug 1, 2024
@brianmcgee
Copy link
Collaborator Author

Just because you use LVM doesn't necessarily mean you are using snapshots. This logic needs to be refined.

#9 might also provide the info necessary for this logic, tbd.

Here's some context as to where this logic came from: NixOS/nixpkgs#33646

@r-vdp
Copy link

r-vdp commented Sep 20, 2024

On the other hand, just because a volume doesn't have snapshots at the time you run nixos-facter, doesn't mean that no snapshots could be created at a later point. So I think always adding the module when LVM is detected is actually the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants