You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2738 introduced nixpkgs.useGlobalPackages which currently defaults to true, however it should really default to false.
Motivation
Using a nixpkgs from our flake.lock will reduce mismatched pkgs version errors
Using an internally constructed nixpkgs instance allows users to configure config, overlays, etc as nixvim module options
Issues
This is a breaking change, especially if users have configured config, overlays, etc outside of Nixvim and expect that config to be inherited by nixvim.
Deprecation
I don't know an obnoxious way to warn users the default value will/has change.
Currently the plan is documented as a literalMD default-text.
Pre-migration, we could warn if users have not explicitly defined the option (i.e. highestPrio == 1500). This would be a very visible and obnoxious warning, and would require users to explicitly define an option they probably don't care about.
Post-migration, we could warn if users have explicitly overridden the default to be false. This would notify users that have migrated early they no longer need to do so explicitly, however it is a bit heavy handed.
The text was updated successfully, but these errors were encountered:
I was thinking about this recently, actually, and I agree. While working on refactoring my neovim flake and playing around with inputs, passing pkgs, and using nixpkgs.pkgs. It felt like it would be really easy to cause the package mismatches we've been seeing lots of issues around.
#2738 introduced
nixpkgs.useGlobalPackages
which currently defaults totrue
, however it should really default tofalse
.Motivation
config
,overlays
, etc as nixvim module optionsIssues
This is a breaking change, especially if users have configured
config
,overlays
, etc outside of Nixvim and expect that config to be inherited by nixvim.Deprecation
I don't know an obnoxious way to warn users the default value will/has change.
Currently the plan is documented as a
literalMD
default-text.Pre-migration, we could warn if users have not explicitly defined the option (i.e.
highestPrio == 1500
). This would be a very visible and obnoxious warning, and would require users to explicitly define an option they probably don't care about.Post-migration, we could warn if users have explicitly overridden the default to be
false
. This would notify users that have migrated early they no longer need to do so explicitly, however it is a bit heavy handed.The text was updated successfully, but these errors were encountered: