Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview action doesnt include preview path in the links for subpages #42

Open
sarcasticadmin opened this issue Feb 13, 2024 · 0 comments
Open

Preview action doesnt include preview path in the links for subpages #42

sarcasticadmin opened this issue Feb 13, 2024 · 0 comments

Comments

@sarcasticadmin
Copy link
Contributor

Description

The preview action is working for PRs but the links on under the preview pages: pr-review/pr-<num> still have the production non preview links. This can be confusing for reviews who dont notice the URL subtleties

Example: https://nixcon.github.io/2024-na.nixcon.org/pr-preview/pr-41/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarcasticadmin