diff --git a/exclusions.md b/exclusions.md index 32ce7b3..80d80aa 100644 --- a/exclusions.md +++ b/exclusions.md @@ -3,6 +3,7 @@ but which we did not include in the main table of our paper. The purpose of this document is to explain why each of these bugs was excluded. The excluded bugs are: * NA-89 +* NA-791B * CF-3025 ## NA-89 @@ -12,6 +13,18 @@ on the original program. Building a SNAPSHOT version of NullAway just to test NA-89 is out of scope for an evaluation script, so we exclude this bug. +## NA-791B + +NA-791B is not reproducible in the reported target file. While the same crash +occurs while running NullAway on the original codebase, we do not receive the +error because: + +1. NullAway runs successfully on the target file _or_ +2. NullAway is crashing before it can reach the target file (more likely) + +Since we cannot verify that the bug is reproducible on the target file, we +exclude this bug. + ## CF-3025 This bug is an interesting case. Briefly, the bug was triggered originally diff --git a/resources/test_data.json b/resources/test_data.json index e1d06d6..3bcc41c 100644 --- a/resources/test_data.json +++ b/resources/test_data.json @@ -845,7 +845,7 @@ ], "bug_pattern": { "file_pattern": "(\\w+\\.java)", - "error_pattern": "warning: (.*)" + "error_pattern": "error: (.*)" }, "version": "0.10.6", "java_version": "11", @@ -855,6 +855,38 @@ "checker_qual_required": false, "has_dependency": false }, + { + "issue_id" : "na-705-jar", + "url": "https://github.com/theron-wang/caffeine.git", + "issue_url": "https://github.com/uber/NullAway/issues/705", + "test_case_url": "https://github.com/uber/NullAway/issues/705#issuecomment-1368082909", + "branch": "na-705", + "commit_hash": "", + "project_name": "caffeine", + "build_command": "", + "root_dir": "guava/src/main/java/", + "targets": [ + { + "method": "", + "field": "entrySet", + "file": "CaffeinatedGuavaCache.java", + "package": "com.github.benmanes.caffeine.guava", + "inner_class": "AsMapView", + "model": "nullaway" + } + ], + "bug_pattern": { + "file_pattern": "(\\w+\\.java)", + "error_pattern": "error: (.*)" + }, + "version": "0.10.6", + "java_version": "11", + "note": "na-705 is the same, but runs without the checker jar (checker_qual_required).", + "bug_type": "false_positive", + "release_url": "https://github.com/uber/NullAway/archive/refs/tags", + "checker_qual_required": true, + "has_dependency": false + }, { "issue_id" : "na-791a", "url": "https://github.com/theron-wang/caffeine.git",