Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rr:predicateMap? #31

Open
jensscheerlinck opened this issue Nov 28, 2018 · 3 comments
Open

Support for rr:predicateMap? #31

jensscheerlinck opened this issue Nov 28, 2018 · 3 comments

Comments

@jensscheerlinck
Copy link

jensscheerlinck commented Nov 28, 2018

When trying to use a rr:predicateMap with a rr:column or rr:template value, the parsers produces no results.

Example:

rr:predicateObjectMap [
		rr:predicateMap [ rr:column 'TestColumn' ];
		rr:objectMap [
			rr:parentTriplesMap map:RechtsbronDocument; 
			rr:joinCondition [
				rr:child 'ChildColumn';
				rr:parent 'ParentColumn';
			]
		]
	].

I only get the desired triples when using rr:predicateMap [ rr:constant ex:test ] or rr:predicate ex:test

@nkons
Copy link
Owner

nkons commented Dec 3, 2018

Hi,

Thanks for reporting this.

In a rr:predicateMap, only an rr:constant is implemented. rr:column and rr:template are not implemented. To implement these would mean parsing them inside the loop in [1], in which only rr:constant is currently parser. A possible workaround would be creating one rr:predicateObjectMap per value in the TestColumn. Since these values are meant to be properties, I would assume their number is manageable?

  1. https://github.com/nkons/r2rml-parser/blob/master/src/main/java/gr/seab/r2rml/beans/Parser.java#L290

@jensscheerlinck
Copy link
Author

jensscheerlinck commented Dec 4, 2018

Hi,

Thanks for the response.

Unfortunately we have some 30 different values in the 'TestColumn'. Currently we have indeed split these up into 30 different maps. Which has a big impact on performance.

Creating different rr:predicateObjectMap elements would also be a possibility. However, we also tried this out before and the result was a very sparse matrix that made overall performance even worse.

@mmopitz
Copy link
Contributor

mmopitz commented Apr 30, 2019

Hi there.
I was just wondering if you plan to support this feature in the near future?
I'm currently running with the workaround mentioned above, but it would greatly simplify my mapping file if I could just use rr:templates in predicate position ;-)

mmopitz added a commit to mmopitz/r2rml-parser that referenced this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants