Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As suggested by @yonicd do a reverse dependency check for rxode2 too #816

Open
mattfidler opened this issue Dec 1, 2024 · 3 comments
Open

Comments

@mattfidler
Copy link
Member

I think he said that the repositories that do this are here:

https://github.com/yonicd/slackposts

@mattfidler
Copy link
Member Author

@yonicd I'm having a hard time finding the github workflow, if/when you get time can you point me to it. It isn't super urgent, but it would be appreciated.

@yonicd
Copy link

yonicd commented Dec 2, 2024

@mattfidler here are some resources for setting it up. If you need to have a short meeting for more hands on explanations or a PR let me know. Happy to contribute.

Slides from talk about some non-conventional gha usage

repo setup:

Notes

  • The workflows are pretty old so they probably can use some dusting off with more current inner steps/caching

Extensions

  • This workflow may also be interesting to you. I was experimenting with the idea of splitting up a workflow into cached steps that would only trigger if the relevant file would have a hash change. (think {targets} for gha @billdenney)
    • The idea being that not all changes warrant a full workflow run (DESCRIPTION/README/Vignettes), this is very helpful on expensive and complicated setups with heavy dependencies across repos.
  • You may also find slides +20 that explain the {shield} workflow also interesting. It basically tries to create more space between your repos and CRAN, with the thinking that once a package gets updated on CRAN and breaks something in your package you are caught flat footed and need to quickly react and be at the mercy of certain cranky CRAN maintainers moods. Shield will run your cmd checks as if you were depending on the main branch of the dependency and not the CRAN tip (I like to get bad news as early as possible).

@mattfidler
Copy link
Member Author

Thanks so much @yonicd !!!

I will take this to the nlmixr2 team. I think we will probably need to decide if we will be combining the nlmixr2 package before applying this. With that being said, I think we will work on this starting Jan. I hope you have a great holiday season 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants