Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add discard body weights to wtatage.ss #575

Open
Rick-Methot-NOAA opened this issue Feb 27, 2024 · 0 comments
Open

[Feature]: add discard body weights to wtatage.ss #575

Rick-Methot-NOAA opened this issue Feb 27, 2024 · 0 comments
Assignees
Labels
discard & retention duplicate This issue or pull request already exists wishlist request new feature; bigger than revision; OK to remove after adding to Milestone
Milestone

Comments

@Rick-Methot-NOAA
Copy link
Collaborator

Rick-Methot-NOAA commented Feb 27, 2024

Describe the solution you would like.

need for this came up in the North Sea sole 2024 assessment with Iago and Max
probably redundant issue to #81

Describe alternatives you have considered

make discard a separate fleet.
Propose doing this by re-purposing the existing field for "birthseason" to partition. It seems highly unlikely that an empirical wtatage model would ever use birthseason (aka settlement event). That is a feature designed by age-length models that are looking at details of seasonal growth.
Currently, SS3 reads values for:
#Yr Seas Sex Bio_Pattern BirthSeas Fleet
but the sex, Bio_pattern and birthseason fields combined into "g" index for the working array. So, effectively only sex is operational:

      gg = tempvec(3);
      gp = tempvec(4);
      birthseas = tempvec(5);
      g = (gg - 1) * N_GP * nseas + (gp - 1) * nseas + birthseas; //  note  cannot handle platoons
Wt_Age_t(t, f, g, a )  is working array

PROBLEM:
expected discard does not directly refer to wt_age_t, it gets discard from total catch - retained catch biomass
else if (catchunits(f) == 1) // biomass units for retained and discarded catch
{ exp_disc(f, j) = catch_fleet(t, f, 1) - catch_fleet(t, f, 3); // discard in biomass

So I see that implementing this feature would require major changes and testing with current discard models

Statistical validity, if applicable

provides flexibility to more accurately mimic the real world situation

Describe if this is needed for a management application

yes. North Sea sole

Additional context

No response

@Rick-Methot-NOAA Rick-Methot-NOAA added wishlist request new feature; bigger than revision; OK to remove after adding to Milestone discard & retention labels Feb 27, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.23 milestone Feb 27, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA self-assigned this Feb 27, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA added the duplicate This issue or pull request already exists label Apr 29, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA modified the milestones: 3.30.23, 3.30.24 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discard & retention duplicate This issue or pull request already exists wishlist request new feature; bigger than revision; OK to remove after adding to Milestone
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant