Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "inf" value in bootstrap of mean size-at-age data for ages with sample size 0 #598

Open
2 tasks
iantaylor-NOAA opened this issue May 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working; don't remove label after fixing misc. output

Comments

@iantaylor-NOAA
Copy link
Contributor

Describe the bug

@e-perl-NOAA reported "inf" values in the bootstraps of the mean size-at-age data for the BigSkate_2019 test model.
I was able to replicate the issue in the attached files.

There is a single vector of observations where the last three bins (for males age 13-15) have 0 sample size. The bootstrap observations are reported as inf 0.0001 inf in data_boot_001.ss and as 0.0001 inf inf in data_boot_002.ss in the attached files:
boot.zip.

It looks like the code here may be randomly generating a mix of inf and -inf and then replacing the -inf with 0.0001.
https://github.com/nmfs-ost/ss3-source-code/blob/main/SS_write_ssnew.tpl#L1271-L1275

I think the following steps should be taken:

  • decide on a placeholder value for the observation. SS3 doesn't like NA (or inf) as an input value here. I used 99.9 in the original Big Skate model, perhaps because it was closer to the range of observed non-placeholder values whereas 999 would have messed up scaling in any rudimentary plot of the results before filtering those observations).
  • add a test for obs_ms_n(f, i, a) == 0 and use the placeholder value instead of generating a bootstrap value

Note that these data are excluded from the likelihood with a lambda = 0 setting, but I think that doesn't matter for any of this.

To Reproduce

Run the attached input files (which is just the BigSkate_2019 in ss3-test-models with the starter file changed to produce bootstrap files).

Expected behavior

A model without inf output that can be used as an SS3 input file.

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

No response

Additional Context

No response

@iantaylor-NOAA iantaylor-NOAA added bug Something isn't working; don't remove label after fixing misc. output labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working; don't remove label after fixing misc. output
Projects
None yet
Development

No branches or pull requests

2 participants