Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update compare.R to include more quantities from ss_summary.sso #4

Open
k-doering-NOAA opened this issue Apr 5, 2021 · 3 comments
Open

update compare.R to include more quantities from ss_summary.sso #4

k-doering-NOAA opened this issue Apr 5, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@k-doering-NOAA
Copy link
Contributor

@Rick-Methot-NOAA identified a change in SmryBio and TotalBio quanities that jenkins was not flagging. It would be helpful to compare more values in the compare script that compares values in SS to a reference model run's ss_summary.sso in order to catch these sorts of issues. Note that the log likelihoods did not change in this case, so the issue was not detectable through other quantities.
@k-doering-NOAA k-doering-NOAA added the enhancement New feature or request label Apr 5, 2021
@k-doering-NOAA k-doering-NOAA self-assigned this Apr 5, 2021
@k-doering-NOAA
Copy link
Contributor Author

Verified via a Jenkins run that this issue was not flagged.

@k-doering-NOAA k-doering-NOAA changed the title update compare.R to include more quanities from ss_summary.sso update compare.R to include more quantities from ss_summary.sso Apr 9, 2021
@k-doering-NOAA
Copy link
Contributor Author

I am planning to work on this after the next release.

@Rick-Methot-NOAA Rick-Methot-NOAA mentioned this issue Aug 20, 2021
Closed
@k-doering-NOAA k-doering-NOAA mentioned this issue Sep 16, 2021
Open
@k-doering-NOAA
Copy link
Contributor Author

k-doering-NOAA commented Dec 13, 2021 •
edited
Loading

Specifically, add comparisons for derived values in the last year of the forecast (ForeCatch and SSB in particular). Change could be made around here: https://github.com/nmfs-stock-synthesis/ss-test-models/blob/4b69768b4e31b7918cfd2b6fe8f50a443614af72/.github/r_scripts/compare.R#L256

@k-doering-NOAA k-doering-NOAA removed their assignment Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@k-doering-NOAA