From ee7feac84138fc4b9d64d04f56f5b4e015ad72ec Mon Sep 17 00:00:00 2001
From: Stefanos Stefanou <stefanos.stefanou@century.tech>
Date: Thu, 2 Nov 2023 11:27:35 +0000
Subject: [PATCH] Arity and productN

---
 .../mycats/instances/OptionInstances.scala    |  7 +-----
 .../scala/mycats/lib/syntax/ApplySyntax.scala |  4 ++--
 .../scala/mycats/lib/ApplyAritySpec.scala     | 22 ++++++-------------
 3 files changed, 10 insertions(+), 23 deletions(-)

diff --git a/src/main/scala/mycats/instances/OptionInstances.scala b/src/main/scala/mycats/instances/OptionInstances.scala
index e6d5127..67d7451 100644
--- a/src/main/scala/mycats/instances/OptionInstances.scala
+++ b/src/main/scala/mycats/instances/OptionInstances.scala
@@ -13,12 +13,7 @@ object OptionInstances {
     }
   }
   implicit val optionalApplyInstance:Apply[Option] = new Apply[Option] {
-    override def product[A, B](a:  Option[A], b:  Option[B]): Option[(A, B)] = {
-      (a,b) match {
-        case (Some(a),Some(b))=>Some((a,b))
-        case _ => None
-      }
-    }
+    override def product[A, B](a:  Option[A], b:  Option[B]): Option[(A, B)] = optionalSemigroupalInstance.product(a,b)
     override def ap[A, B](ff:  Option[A => B])(fa:  Option[A]): Option[B] = ???
     override def map[A, B](fa:  Option[A])(f:  A => B): Option[B] = fa match {
       case Some(value) => Some(f(value))
diff --git a/src/main/scala/mycats/lib/syntax/ApplySyntax.scala b/src/main/scala/mycats/lib/syntax/ApplySyntax.scala
index 1cf4011..8cc0917 100644
--- a/src/main/scala/mycats/lib/syntax/ApplySyntax.scala
+++ b/src/main/scala/mycats/lib/syntax/ApplySyntax.scala
@@ -3,7 +3,7 @@ import mycats.lib.morphisms.{Apply, Semigroupal}
 
 object ApplySyntax {
   implicit class applyAritySyntaxOps[F[_],A](fa:F[A]){
-    def product[B](fb:F[B])(implicit semigroupalF:Semigroupal[F]) = semigroupalF.product(fa,fb)
-    def product[B,C](fb:F[B],fc:F[C])(implicit apply:Apply[F]) = apply.product2(fa,fb,fc)
+    def productN[B](fb:F[B])(implicit semigroupalF:Semigroupal[F]) = semigroupalF.product(fa,fb)
+    def productN[B,C](fb:F[B],fc:F[C])(implicit apply:Apply[F]) = apply.product2(fa,fb,fc)
   }
 }
diff --git a/src/test/scala/mycats/lib/ApplyAritySpec.scala b/src/test/scala/mycats/lib/ApplyAritySpec.scala
index fd9c863..bc38703 100644
--- a/src/test/scala/mycats/lib/ApplyAritySpec.scala
+++ b/src/test/scala/mycats/lib/ApplyAritySpec.scala
@@ -1,22 +1,14 @@
 package mycats.lib
-
-import mycats.instances.OptionInstances.optionalSemigroupalInstance
-import mycats.lib.syntax.SemigroupalSyntax._
-import mycats.instances.OptionInstances.optionalApplyInstance
 import mycats.lib.morphisms.Apply
-import mycats.lib.morphisms.arity.ApplyArityFunctions
+import mycats.instances.OptionInstances.optionalApplyInstance
 import mycats.lib.syntax.ApplySyntax.applyAritySyntaxOps
-//There is some sources
+
 class ApplyAritySpec extends org.scalatest.funsuite.AnyFunSuite {
   test("Apply Law : Arity 2 : Product should be associative") {
-//    implicit val he:Apply[Option] = optionalApplyInstance
-//    val opt1:Option[Int]=Some(32)
-//    val opt2:Option[String]=Some("Hello world")
-//    val opt3:Option[Double]=Some(42.42)
-//
-//    val left = applyAritySyntaxOps(opt1).product(opt2)(he)
-//    val right = opt2.product(opt2,opt3)(he)
-//
-//    assert(optionalApplyInstance.pro(opt1,opt2,opt3)) ,"Semigroupal is not associative?")
+    val opt1:Option[Int]=Some(32)
+    val opt2:Option[String]=Some("Hello world")
+    val opt3:Option[Double]=Some(42.42)
+    //assert((opt1.productN(opt2)).productN(opt3) == opt1.productN(opt2.productN(opt3)) ,"Semigroupal is not associative?")
+    //wait for answer https://medium.com/@PerrottaFrancisco/semigroupal-parallel-applicative-in-cats-6df527b853da
   }
 }