Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution order #7

Closed
ghost opened this issue Sep 15, 2020 · 6 comments · Fixed by #8
Closed

Execution order #7

ghost opened this issue Sep 15, 2020 · 6 comments · Fixed by #8

Comments

@ghost
Copy link

ghost commented Sep 15, 2020

https://github.com/noaa-ocs-modeling/NEMSpy/blob/33323ae4135ca0b9cd3679bd7e53f6919afc0ad2/examples/example_1.py#L15-L20
How is the execution order defined?

@ghost
Copy link

ghost commented Sep 15, 2020

https://github.com/noaa-ocs-modeling/NEMSpy/blob/33323ae4135ca0b9cd3679bd7e53f6919afc0ad2/examples/example_1.py#L11-L20

the order is currently defined by the .__init__() order, but I'm trying to think of a better way to define that more explicitly

@ghost
Copy link

ghost commented Sep 15, 2020

I've added an initial implementation in 36bcb8e to make the sequence transparent and mutable from the interface level

@ghost
Copy link

ghost commented Sep 15, 2020

made a pull request (#8 ) for mutable sequence

@ghost ghost self-assigned this Sep 15, 2020
@jreniel
Copy link
Contributor

jreniel commented Sep 15, 2020

https://github.com/noaa-ocs-modeling/NEMSpy/blob/33323ae4135ca0b9cd3679bd7e53f6919afc0ad2/examples/example_1.py#L11-L20

the order is currently defined by the .__init__() order, but I'm trying to think of a better way to define that more explicitly

I think we might need more than that, since the execution is not just about ordering, it can also call specific functions from the CAP. In this case, I think we need to make it so that the user builds the whole sequence (connectors, executors and subsequences) from the API methods.

@ghost
Copy link

ghost commented Sep 16, 2020

alright, I will keep working on that

@ghost ghost linked a pull request Sep 23, 2020 that will close this issue
@ghost
Copy link

ghost commented Sep 23, 2020

sequence API implemented in #8; second half of this issue is moved to #13

@ghost ghost closed this as completed Sep 23, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant