Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in Kalman Filter C++ implementation #105

Open
BogdanovKirill opened this issue Sep 5, 2023 · 1 comment
Open

Possible bug in Kalman Filter C++ implementation #105

BogdanovKirill opened this issue Sep 5, 2023 · 1 comment

Comments

@BogdanovKirill
Copy link

Hello,

It seems that we should replace this wrong line:
P = _alpha_sq * ((F * P), F.transpose()) + Q;
by this:
P = _alpha_sq * ((F * P) * F.transpose()) + Q;

See python reference code:
self.P = self._alpha_sq * dot(dot(F, self.P), F.T) + Q

https://github.com/noahcao/OC_SORT/blame/7a390a5f35dbbb45df6cd584588c216aea527248/deploy/OCSort/cpp/src/KalmanFilter.cpp#L29

@JeffCheng95
Copy link

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants