Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Support Transient Properties #68

Closed
labancap opened this issue Nov 21, 2014 · 4 comments · Fixed by #82
Closed

Support Transient Properties #68

labancap opened this issue Nov 21, 2014 · 4 comments · Fixed by #82

Comments

@labancap
Copy link

Any idea when this will be supported? This is a very basic feature that should be supported.

@noamt
Copy link
Owner

noamt commented Nov 24, 2014

Pull requests are gladly accepted

@labancap
Copy link
Author

I'll try. I was just hoping since you maintain the plugin that you would be able to do this a lot faster than me since I will have to reverse engineer the plugin.

@labancap
Copy link
Author

I have created the ability to specify a "transientProperties" array in the searchable mapping in the same way you can use "only" or "except". I thought that was a best way to prevent any breaking changes. If you think it would not hurt to just make it default to include transient properties, I could probably make that work as well. If not, I'll submit the pull request as-is. It follows the advice of this thread:
mstein#17

@noamt
Copy link
Owner

noamt commented Dec 1, 2014

Sounds good, submit whatever you've got; Just make sure to add some adequate test cases and documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants