Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch.aten.max_unpool2d #764

Closed
Tracked by #347
Hardcode84 opened this issue Jul 3, 2024 · 4 comments
Closed
Tracked by #347

torch.aten.max_unpool2d #764

Hardcode84 opened this issue Jul 3, 2024 · 4 comments

Comments

@Hardcode84
Copy link

No description provided.

@Hardcode84 Hardcode84 mentioned this issue Jul 3, 2024
Open
80 tasks
@Hardcode84 Hardcode84 self-assigned this Jul 3, 2024
@Hardcode84
Copy link
Author

Hardcode84 commented Jul 30, 2024 •
edited
Loading

PR for max_unpool3d was merged (#765), but unfortunately, this approach won't work for max_unpool2d as corresponding aten node preserve even less info than max_unpool3d, we need a different approach, either lowering directly to (parallel) scf loops or ONNX->linalg lowering, skipping aten op. See max_unpool3d issue and PR for details.

@Hardcode84 Hardcode84 removed their assignment Jul 30, 2024
@vivekkhandelwal1
Copy link
Contributor

Hi @Hardcode84, are you still working on this op?

@Hardcode84
Copy link
Author

Hi, @vivekkhandelwal1, I did max_unpool3d but I'm not working on max_unpool2d currently.

@marbre marbre assigned marbre and unassigned marbre Aug 16, 2024
@jinchen62
Copy link
Contributor

Duplicate issue of #718, so close this.

@jinchen62 jinchen62 mentioned this issue Oct 8, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hardcode84 @marbre @jinchen62 @vivekkhandelwal1