Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the gitignore for the deploy directory #203

Open
danielo515 opened this issue Feb 11, 2021 · 1 comment
Open

Improve the gitignore for the deploy directory #203

danielo515 opened this issue Feb 11, 2021 · 1 comment

Comments

@danielo515
Copy link

danielo515 commented Feb 11, 2021

Hello.
I just noticed that I accidentally committed the deploy folder (I'm not using a template per se). I deleted it, tried to package and the package indeed fails. Then I come back to the documentation and saw that we are supposed to keep this directory.
But it will contain also build artifacts that I don't think we are supposed to keep.
Probably the right config for gitignore is

deploy/*
!deploy/config.json

Am I right?

@danielo515 danielo515 changed the title If we should commit the dist folder, why is it on gitignore by default Improve the gitignore for the deploy directory Feb 11, 2021
@danielo515
Copy link
Author

Ok, now I see that we are supposed to keep the entire deploy directory and only ignore the build inside it.
This makes me think that it is not possible to build for the different platforms on CI, because we need a set of templates that are not present unless we commit them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant