add test and tidy up

nodejs · Feb 23, 2025 · 7d2cab1 · 7d2cab1
1 parent 931c797
commit 7d2cab1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/path.js b/lib/path.js
@@ -736,7 +736,7 @@ const win32 = {
 
     const code = StringPrototypeCharCodeAt(path, 0);
     if (len === 1) return isPathSeparator(code) ? path : '.';
-    if (len === 2 && isPathSeparator(StringPrototypeCharCodeAt(path, 1))) return path;
+    if (len === 2 && isPathSeparator(StringPrototypeCharCodeAt(path, 1))) return isPathSeparator(code) ? path[0] : '.';
 
     let rootEnd = -1;
     let offset = 0;

diff --git a/test/parallel/test-path-dirname.js b/test/parallel/test-path-dirname.js
@@ -8,9 +8,12 @@ assert.strictEqual(path.dirname(__filename).slice(-13),
 
 assert.strictEqual(path.posix.dirname('/a/b/'), '/a');
 assert.strictEqual(path.posix.dirname('/a/b'), '/a');
+assert.strictEqual(path.posix.dirname('a/'), '.');
 assert.strictEqual(path.posix.dirname('/a'), '/');
 assert.strictEqual(path.posix.dirname(''), '.');
+assert.strictEqual(path.posix.dirname('ab'), '.');
 assert.strictEqual(path.posix.dirname('/'), '/');
+assert.strictEqual(path.posix.dirname('//'), '/');
 assert.strictEqual(path.posix.dirname('////'), '/');
 assert.strictEqual(path.posix.dirname('//a'), '//');
 assert.strictEqual(path.posix.dirname('foo'), '.');
@@ -53,6 +56,9 @@ assert.strictEqual(path.win32.dirname('\\\\unc\\share\\foo\\bar\\baz'),
 assert.strictEqual(path.win32.dirname('/a/b/'), '/a');
 assert.strictEqual(path.win32.dirname('/a/b'), '/a');
 assert.strictEqual(path.win32.dirname('/a'), '/');
+assert.strictEqual(path.win32.dirname('a/'), '.');
+assert.strictEqual(path.win32.dirname('ab'), '.');
+assert.strictEqual(path.win32.dirname('//'), '/');
 assert.strictEqual(path.win32.dirname(''), '.');
 assert.strictEqual(path.win32.dirname('/'), '/');
 assert.strictEqual(path.win32.dirname('////'), '/');