From 9840ca3348ad45a10176bc4d1806b55dbea3bc6e Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Tue, 25 Feb 2025 22:42:33 +0100 Subject: [PATCH] test: resolve race condition in test-net-write-fully-async-* Signed-off-by: Matteo Collina PR-URL: https://github.com/nodejs/node/pull/57022 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli --- test/parallel/test-net-write-fully-async-buffer.js | 6 +++--- test/parallel/test-net-write-fully-async-hex-string.js | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-net-write-fully-async-buffer.js b/test/parallel/test-net-write-fully-async-buffer.js index 3a3426ba703845..4dfb905d23b69e 100644 --- a/test/parallel/test-net-write-fully-async-buffer.js +++ b/test/parallel/test-net-write-fully-async-buffer.js @@ -11,14 +11,14 @@ const data = Buffer.alloc(1000000); const server = net.createServer(common.mustCall(function(conn) { conn.resume(); + server.close(); })).listen(0, common.mustCall(function() { const conn = net.createConnection(this.address().port, common.mustCall(() => { let count = 0; function writeLoop() { - if (count++ === 200) { - conn.destroy(); - server.close(); + if (count++ === 20) { + conn.end(); return; } diff --git a/test/parallel/test-net-write-fully-async-hex-string.js b/test/parallel/test-net-write-fully-async-hex-string.js index 48c54819b3b676..c1ebe7e68b534e 100644 --- a/test/parallel/test-net-write-fully-async-hex-string.js +++ b/test/parallel/test-net-write-fully-async-hex-string.js @@ -9,14 +9,14 @@ const data = Buffer.alloc(1000000).toString('hex'); const server = net.createServer(common.mustCall(function(conn) { conn.resume(); + server.close(); })).listen(0, common.mustCall(function() { const conn = net.createConnection(this.address().port, common.mustCall(() => { let count = 0; function writeLoop() { if (count++ === 20) { - conn.destroy(); - server.close(); + conn.end(); return; }