Skip to content

Commit

Permalink
test, crypto: use correct object on assert
Browse files Browse the repository at this point in the history
The test case for KeyObject does not really test the creation of
asymmetric cryptographic keys using jwk because of a misspelling of
the variable.

PR-URL: #51820
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
  • Loading branch information
xicilion authored and marco-ippolito committed Jun 17, 2024
1 parent e19c60c commit 9d6d80b
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions test/parallel/test-crypto-key-objects.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,16 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
assert.strictEqual(derivedPublicKey.symmetricKeySize, undefined);

const publicKeyFromJwk = createPublicKey({ key: publicJwk, format: 'jwk' });
assert.strictEqual(publicKey.type, 'public');
assert.strictEqual(publicKey.toString(), '[object KeyObject]');
assert.strictEqual(publicKey.asymmetricKeyType, 'rsa');
assert.strictEqual(publicKey.symmetricKeySize, undefined);
assert.strictEqual(publicKeyFromJwk.type, 'public');
assert.strictEqual(publicKeyFromJwk.toString(), '[object KeyObject]');
assert.strictEqual(publicKeyFromJwk.asymmetricKeyType, 'rsa');
assert.strictEqual(publicKeyFromJwk.symmetricKeySize, undefined);

const privateKeyFromJwk = createPrivateKey({ key: jwk, format: 'jwk' });
assert.strictEqual(privateKey.type, 'private');
assert.strictEqual(privateKey.toString(), '[object KeyObject]');
assert.strictEqual(privateKey.asymmetricKeyType, 'rsa');
assert.strictEqual(privateKey.symmetricKeySize, undefined);
assert.strictEqual(privateKeyFromJwk.type, 'private');
assert.strictEqual(privateKeyFromJwk.toString(), '[object KeyObject]');
assert.strictEqual(privateKeyFromJwk.asymmetricKeyType, 'rsa');
assert.strictEqual(privateKeyFromJwk.symmetricKeySize, undefined);

// It should also be possible to import an encrypted private key as a public
// key.
Expand Down

0 comments on commit 9d6d80b

Please sign in to comment.