Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,build: add no user defined deduction guides of CTAD check #56071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

legendecas
Copy link
Member

To our secondary C++ style guide:

Do not use CTAD with a given template unless the template's maintainers have opted into supporting use of CTAD by providing at least one explicit deduction guide (all templates in the std namespace are also presumed to have opted in). This should be enforced with a compiler warning if available.

Ref: https://google.github.io/styleguide/cppguide.html#CTAD

To use CTAD with a template, it must be defined with at least one deduction guide (std templates are defined with guides). Enforcing this rule with compiler checks.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 29, 2024
@legendecas legendecas changed the title build: add no user defined deduction guides of CTAD check src,build: add no user defined deduction guides of CTAD check Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (d09458f) to head (8d59040).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/quic/session.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56071      +/-   ##
==========================================
+ Coverage   87.96%   88.01%   +0.04%     
==========================================
  Files         656      656              
  Lines      188384   188988     +604     
  Branches    35968    35989      +21     
==========================================
+ Hits       165707   166331     +624     
- Misses      15845    15846       +1     
+ Partials     6832     6811      -21     
Files with missing lines Coverage Δ
src/quic/session.cc 5.35% <0.00%> (ø)

... and 31 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants