net: support blocklist in net.connect #56075
Open
+102
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
errors
jasnell
reviewed
Nov 29, 2024
jasnell
reviewed
Nov 29, 2024
lib/net.js
Outdated
| @@ -510,6 +511,13 @@ function Socket(options) { | |||
| // Used after `.destroy()` | |||
| this[kBytesRead] = 0; | |||
| this[kBytesWritten] = 0; | |||
| if (options.blockList) { | |||
| if (options.blockList instanceof module.exports.BlockList) { | |||
There was a problem hiding this comment.
TODO for later... we should have a more efficient isBlockList(...) API
jasnell
approved these changes
Nov 29, 2024
theanarkh
force-pushed
the
support_blocklist_in_net_connect
branch
from
176a993
to
e6be3e3
Compare
lpinca
approved these changes
Nov 29, 2024
lpinca
added
the
semver-minor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56075 +/- ##
==========================================
+ Coverage 88.00% 88.02% +0.01%
==========================================
Files 656 656
Lines 188988 189014 +26
Branches 35992 35999 +7
==========================================
+ Hits 166315 166371 +56
+ Misses 15838 15823 -15
+ Partials 6835 6820 -15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first PR for #55000
make -j4 test(UNIX), orvcbuild test(Windows) passes