Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add net.BlockList.isBlockList(value) #56078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

net: add net.BlockList.isBlockList(value) #56078

wants to merge 1 commit into from
+23 −0

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 29, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63779/

anonrig
anonrig approved these changes Nov 29, 2024
View reviewed changes
lib/internal/blocklist.js Show resolved Hide resolved
@anonrig anonrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024
lpinca
lpinca approved these changes Nov 29, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (4efb7ae) to head (01f2756).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56078      +/-   ##
==========================================
- Coverage   87.99%   87.99%   -0.01%     
==========================================
  Files         656      656              
  Lines      188988   188997       +9     
  Branches    35988    35988              
==========================================
+ Hits       166302   166309       +7     
+ Misses      15848    15846       -2     
- Partials     6838     6842       +4
Files with missing lines Coverage Δ
lib/internal/blocklist.js 98.85% <100.00%> (+0.06%) ⬆️

... and 28 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theanarkh theanarkh theanarkh approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @lpinca @anonrig @theanarkh