lib: optimize priority queue

[gurgunday]

Huge credit to @lemire, I only ported the parts that we can to improve performance without introducing breaking changes

First run:

After:

util/priority-queue.js

util/priority-queue.js n=100000: 6,372,311.7447058195

Before:

util/priority-queue.js

util/priority-queue.js n=100000: 5,610,982.713123359

Second run:

After:

util/priority-queue.js

util/priority-queue.js n=100000: 6,524,784.786498602

Before:

util/priority-queue.js

util/priority-queue.js n=100000: 4,854,606.242159507

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (fd45383) to head (db55a71).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57100   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files         630      630           
  Lines      184634   184645   +11     
  Branches    36137    36126   -11     
=======================================
+ Hits       166654   166675   +21     
+ Misses      11022    11017    -5     
+ Partials     6958     6953    -5     

Files with missing lines	Coverage Δ
lib/internal/priority_queue.js	99.19% <100.00%> (+0.07%)	⬆️

... and 44 files with indirect coverage changes

[gurgunday]

@aduh95 would you like to take a look as well?

[aduh95]

Wouldn't an assert makes more sense here? We probably have a bug if we try to remove something out of range

Suggested change

	if (pos > this.#size) return;
	assert(pos < this.#size);

[gurgunday]

@aduh95 actually I checked again and it was going to be a breaking change this one, because of this:

node/lib/internal/priority_queue.js

Lines 89 to 101 in 25dd206

	removeAt(pos) {
	const heap = this.#heap;
	const size = --this.#size;
	heap[pos] = heap[size + 1];
	heap[size + 1] = undefined;
	if (size > 0 && pos <= size) {
	if (pos > 1 && this.#compare(heap[pos / 2 | 0], heap[pos]) > 0)
	this.percolateUp(pos);
	else
	this.percolateDown(pos);
	}
	}

We'd do the mutation directly but wouldn't enter the if block, now we don't do anything, so I reverted that completely

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1660/

                                confidence improvement accuracy (*)   (**)  (***)
util/priority-queue.js n=100000        ***      7.48 %       ±1.29% ±1.72% ±2.23%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65403/

[gurgunday]

@aduh95 can we try again? I rebased maybe there was a flaky test