lib: expose setupInstance
method on WASI class
#57214
Open
+24
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: nodejs/help#4102
wasip1-threads requires shared memory imported from host and reuse in child threads, and neither
initialize
norstart
should be called in child threads, butWASI
object also need to bind wasm instance and memory in child threads.My current solution is so tricky without accessing
setupInstance
: