-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: swap assert.strictEqual() parameters #57217
base: main
Are you sure you want to change the base?
Conversation
The `actual` and the `expected` parameters are respectively the first and the second.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57217 +/- ##
==========================================
- Coverage 90.27% 90.25% -0.02%
==========================================
Files 630 630
Lines 184634 184634
Branches 36128 36120 -8
==========================================
- Hits 166671 166637 -34
- Misses 11020 11034 +14
- Partials 6943 6963 +20 |
I can never remember the order on these. The ship has long sailed off into the distance but I would have much preferred an API like...
Or something similar that makes it a lot clearer... Ah well, good find. |
@jasnell it's never too late for |
The
actual
and theexpected
parameters are respectively the first and the second.