Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure posts are sorted chronologically #102

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Ensure posts are sorted chronologically #102

merged 5 commits into from
Aug 22, 2024

Conversation

vcarl
Copy link
Contributor

@vcarl vcarl commented Aug 21, 2024

Resolves #99

ovflowd
ovflowd approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments!

scripts/format.js Outdated Show resolved Hide resolved
scripts/format.js Outdated Show resolved Hide resolved
vcarl
vcarl commented Aug 22, 2024
View reviewed changes
scripts/format.js Outdated Show resolved Hide resolved
@UlisesGascon
Copy link
Member

UlisesGascon commented Aug 22, 2024 •
edited
Loading

Thanks @vcarl for doing the PR! :)

Seems like there are some linting issues, can you run npm run lint:fix?

Screenshot from 2024-08-22 19-46-50

@vcarl
Copy link
Contributor Author

vcarl commented Aug 22, 2024 •
edited
Loading

Yep just addressing those! I'm a Prettier kinda guy, Standard is arguing with my choices 😁

@UlisesGascon
Copy link
Member

Not sure why the rss checker is complaining 🤔
Screenshot from 2024-08-22 21-16-58

You can simulate this by running: npm run build && npm run rss:format-check, and then if you run npm run rss:format you can see what have changed

@vcarl
Copy link
Contributor Author

vcarl commented Aug 22, 2024 •
edited
Loading

Caught some quirks, the RSS parser was doing more than I had anticipated — looks like it's omitting description and adding content/contentSnippet which is a change I didn't intend to introduce. Also looks like it's attempting to correct the HTML? I've noticed it adding a <div> around root-level <p> tags in descriptions.

Doing some more local validation here since that's a pretty large/unexpected behavior change, should have it ready soon

UlisesGascon
UlisesGascon approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vcarl for all the work! ❤️

@UlisesGascon UlisesGascon merged commit 486e226 into nodejs:main Aug 22, 2024
1 check passed
@UlisesGascon
Copy link
Member

So... this change was deployed and also I included a content update recently. Let me know if you find any issue @vcarl 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSS feed is out of order
3 participants
@vcarl @UlisesGascon @ovflowd