Skip to content

Commit

Permalink
fix: remove confusing close label for navigation menu (#7463)
Browse files Browse the repository at this point in the history
* fix: remove confusing close label for navigation menu

* use `toggle`

Signed-off-by: Antoine du Hamel <[email protected]>

---------

Signed-off-by: Antoine du Hamel <[email protected]>
  • Loading branch information
aduh95 authored Feb 11, 2025
1 parent a6c0ad9 commit 2bbe0fe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions apps/site/components/Containers/NavBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ const NavBar: FC<NavbarProps> = ({
id="sidebarItemToggler"
type="checkbox"
onChange={e => setIsMenuOpen(() => e.target.checked)}
aria-label={t(
`components.containers.navBar.controls.${isMenuOpen ? 'close' : 'open'}`
)}
aria-label={t(`components.containers.navBar.controls.toggle`)}
/>

<div className={`${style.main} peer-checked:flex`}>
Expand Down
3 changes: 1 addition & 2 deletions packages/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
},
"navBar": {
"controls": {
"open": "Show navigation menu",
"close": "Close navigation menu"
"toggle": "Toggle navigation menu"
},
"links": {
"about": "About",
Expand Down

0 comments on commit 2bbe0fe

Please sign in to comment.