From 2bbe0fe5ae6a3ab810c7c7ac47a403da8444bb75 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Tue, 11 Feb 2025 23:20:47 +0100 Subject: [PATCH] fix: remove confusing close label for navigation menu (#7463) * fix: remove confusing close label for navigation menu * use `toggle` Signed-off-by: Antoine du Hamel --------- Signed-off-by: Antoine du Hamel --- apps/site/components/Containers/NavBar/index.tsx | 4 +--- packages/i18n/locales/en.json | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/apps/site/components/Containers/NavBar/index.tsx b/apps/site/components/Containers/NavBar/index.tsx index 039ea38c8454d..840ef6d242a35 100644 --- a/apps/site/components/Containers/NavBar/index.tsx +++ b/apps/site/components/Containers/NavBar/index.tsx @@ -70,9 +70,7 @@ const NavBar: FC = ({ id="sidebarItemToggler" type="checkbox" onChange={e => setIsMenuOpen(() => e.target.checked)} - aria-label={t( - `components.containers.navBar.controls.${isMenuOpen ? 'close' : 'open'}` - )} + aria-label={t(`components.containers.navBar.controls.toggle`)} />
diff --git a/packages/i18n/locales/en.json b/packages/i18n/locales/en.json index b00f4981e6ca3..a0a3f2b8238a3 100644 --- a/packages/i18n/locales/en.json +++ b/packages/i18n/locales/en.json @@ -12,8 +12,7 @@ }, "navBar": { "controls": { - "open": "Show navigation menu", - "close": "Close navigation menu" + "toggle": "Toggle navigation menu" }, "links": { "about": "About",