Fix: whitespace between the main content and progressive sidebar #7271
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
canerakdas
reviewed
Nov 21, 2024
| sm:p-12; | ||
| sm:p-12 | ||
| lg:sticky | ||
| lg:bottom-[4rem] |
There was a problem hiding this comment.
Suggested change
| lg:bottom-[4rem] | |
| lg:bottom-16 |
In the default Tailwind spacing scale, 16 is equivalent to 4rem
| @@ -61,6 +65,7 @@ | |||
| sticky | |||
| bottom-0 | |||
| flex | |||
| h-[4rem] | |||
There was a problem hiding this comment.
Suggested change
| h-[4rem] | |
| h-16 |
Similarly, you can use h-16
TenzDelek
reviewed
Nov 22, 2024
There was a problem hiding this comment.
hey thanks for the pr, but what i meant in my issue #7251 was not this . while it tackles the main content issue, the sidebar is still having that whitespace behavior which can cause accessibility issue later on. check this sidebar behavior for example. we dont want to scroll all the way up to to navigate to a different content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed whitespace when main content is shorter than sidebar by setting the main content's position to sticky and fixing it to the bottom.
Validation
Left: Before (whitespace under text caused by sidebar height). Right: After (main content sticks to the bottom to eliminate whitespace).
Related Issues
Fixes #7251
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.