Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(git-changelog): support mapAuthors for authors in front matter during dev #280

Open
northword opened this issue Jul 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog

Comments

@northword
Copy link
Member

In build mode, the authors returned by useChangelog() is a complete list of authors, so authors in the front matter can be retrieved with their details (avatars, links, etc.), since the complete Git record is retrieved.

However, under dev, since the VirtualModule only contains data for the current page, the authors in the front matter may not be included in changelog.authors, so their details are not available.

We may need to change the logic to get the front matter of the md file on the vite side instead of the client side.

@northword northword added bug Something isn't working pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog labels Jul 27, 2024
@northword northword self-assigned this Jul 27, 2024
@northword northword changed the title improve: support mapAuthors for authors in front matter during dev improve(git-changelog): support mapAuthors for authors in front matter during dev Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog
Projects
None yet
Development

No branches or pull requests

1 participant