Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

indexer: num_* metrics should use global counts #164

Closed
yourbuddyconner opened this issue Feb 4, 2022 · 2 comments
Closed

indexer: num_* metrics should use global counts #164

yourbuddyconner opened this issue Feb 4, 2022 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@yourbuddyconner
Copy link
Contributor

yourbuddyconner commented Feb 4, 2022

How it is: The indexer counts the number of dispatched/processed/updated/relayed messages since the beginning of the process.

How it should be: The indexer records the global number of dispatched/processed/updated/relayed messages.

Ok to do this incrementally, rather than fetching all events each time these values are updated. (be careful to make sure you're not missing or double-counting any messages if updating incrementally)

Alternative idea: Query the DB for this info such that you don't have to calculate it incrementally.

@yourbuddyconner yourbuddyconner added the bug Something isn't working label Feb 4, 2022
@kekonen kekonen self-assigned this Feb 7, 2022
@kekonen
Copy link
Member

kekonen commented Feb 8, 2022

It actually always keeps a global count and throws them into the metrics, even if u restart the indexer. The point is also to always test the sequence of updates for home and all replicas (rootA -> rootB, rootB -> rootC, ...) and test for missing events. It is also possible to maintain events in the DB and adjust the integrity test, but it will require some work, which is neither in the scope of prioritized tickets (this and #163) nor causing possible problems with Memory (keeping it all in RAM) or taking time on restart (the most of the time-consuming is to collect block data: timestamps and transactions to track the transfer dispatch tx hash and sender, but it is already in the DB). Yet, I created the issue for this #184

@yourbuddyconner yourbuddyconner added the wontfix This will not be worked on label Feb 8, 2022
@yourbuddyconner
Copy link
Contributor Author

Cool thanks @kekonen, closing this issue as a #wontfix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants