fix: handle duplicated channels in tdms #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated tdms channel handling to deal with the same channel names accross different groups * changed merge suffixes to prevent confusion with coordinate systems
mariobuikhuizen
approved these changes
Dec 11, 2024
alkasm
requested changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading TDMS it was found that channels were being repeated across groups. This was due to a dictionary being declared in the incorrect scope resulting in repeated data. This manifested as two channels showing up _x and _y suffixes. This fix does two things.
_repeated_1and_repeated_2to prevent confusion with x and y coordinate systems