From b78e54d1379d3e904bb53158eea5c8d7ebfc1fcc Mon Sep 17 00:00:00 2001 From: imklau Date: Mon, 22 Apr 2024 12:04:33 +0200 Subject: [PATCH 1/4] feat(tabs): update id value --- packages/design-system/patterns/tabs/Tabs.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/design-system/patterns/tabs/Tabs.jsx b/packages/design-system/patterns/tabs/Tabs.jsx index 00f4e377c..b3d91c214 100644 --- a/packages/design-system/patterns/tabs/Tabs.jsx +++ b/packages/design-system/patterns/tabs/Tabs.jsx @@ -48,7 +48,7 @@ const Tabs = ({ data, id, transparentContent, className }) => { active={index === activeIndex} aria-selected={index === activeIndex} aria-controls={`${convertToSlug(id)}-${convertToSlug(tab)}`} - id={convertToSlug(tab)} + id={`${convertToSlug(id)}-${convertToSlug(tab)}`} onClick={() => setActiveIndex(index)} borderBottom={transparentContent || activeIndex !== index} transparentContent={transparentContent} From 7c0d74e4bd95c78e1624d206f252783b5ea8883f Mon Sep 17 00:00:00 2001 From: imklau Date: Mon, 22 Apr 2024 12:07:43 +0200 Subject: [PATCH 2/4] fix(scroll-button): add a default aria label value --- .../design-system/components/scrollButton/ScrollButton.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/design-system/components/scrollButton/ScrollButton.jsx b/packages/design-system/components/scrollButton/ScrollButton.jsx index cf73c9f59..0f2505c3c 100644 --- a/packages/design-system/components/scrollButton/ScrollButton.jsx +++ b/packages/design-system/components/scrollButton/ScrollButton.jsx @@ -29,12 +29,13 @@ ScrollButton.propTypes = { /** * It's used to provide a text description for assistive technologies, like screen readers. */ - ariaLabel: string.isRequired, + ariaLabel: string, className: string, } ScrollButton.defaultProps = { className: null, + ariaLabel: "Przejdź do kolejnej sekcji", } export default ScrollButton From b7359100e76df22cb92c3eb6cf7b7dce0424a4cc Mon Sep 17 00:00:00 2001 From: imklau Date: Mon, 22 Apr 2024 12:09:07 +0200 Subject: [PATCH 3/4] fix: update ids to PL --- packages/frontend/app/templates/Animal/Animal.jsx | 2 +- .../templates/Animal/components/OtherAnimals/OtherAnimals.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/frontend/app/templates/Animal/Animal.jsx b/packages/frontend/app/templates/Animal/Animal.jsx index d35f59778..e9ca73c3c 100644 --- a/packages/frontend/app/templates/Animal/Animal.jsx +++ b/packages/frontend/app/templates/Animal/Animal.jsx @@ -59,7 +59,7 @@ const Animal = ({ data, otherAnimals }) => ( Sprawdź, kto jeszcze czeka na miłość - + diff --git a/packages/frontend/app/templates/Animal/components/OtherAnimals/OtherAnimals.jsx b/packages/frontend/app/templates/Animal/components/OtherAnimals/OtherAnimals.jsx index 4e20eb536..d0f428a78 100644 --- a/packages/frontend/app/templates/Animal/components/OtherAnimals/OtherAnimals.jsx +++ b/packages/frontend/app/templates/Animal/components/OtherAnimals/OtherAnimals.jsx @@ -11,7 +11,7 @@ import * as Styled from "./OtherAnimals.styled" const OtherAnimals = ({ data }) => ( - + Date: Mon, 22 Apr 2024 12:14:04 +0200 Subject: [PATCH 4/4] fix: add missing key to each card --- .../components/TeamCardList/TeamCardList.jsx | 25 ++++++++----------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/packages/frontend/app/templates/FoundationBackstage/components/TeamCardList/TeamCardList.jsx b/packages/frontend/app/templates/FoundationBackstage/components/TeamCardList/TeamCardList.jsx index a4cc0e869..d717e99ad 100644 --- a/packages/frontend/app/templates/FoundationBackstage/components/TeamCardList/TeamCardList.jsx +++ b/packages/frontend/app/templates/FoundationBackstage/components/TeamCardList/TeamCardList.jsx @@ -3,19 +3,16 @@ import Typography from "design-system/components/typography" import { teamData } from "./teamData" import * as Styled from "./TeamCardList.styled" -const CardList = () => ( - - {Object.entries(teamData).map(([category, { title, members }]) => ( - <> - {title} - - {members.map((member) => ( - - ))} - - - ))} - -) +const CardList = () => + Object.entries(teamData).map(([category, { title, members }]) => ( + + {title} + + {members.map((member) => ( + + ))} + + + )) export default CardList